fix(text): avoid mutating accessibilityState - #58318
Closed
mfkrause wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D118788803. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When
accessibilityState.disabledconflicts with an explicitdisabledprop, theTextcomponent currently updatesaccessibilityStatein place. This mutates an object owned by the caller, which can cause issues when other code uses that same object.This fix creates a new object instead, while retaining existing behavior (giving priority to the explicit prop).
Changelog:
[GENERAL] [FIXED] - Prevent Text from mutating the accessibilityState prop
Test Plan:
Unchanged tests pass + added a regression test